Conversation
dkliban
force-pushed
the
7210
branch
14 times, most recently
from
19a5443 to
ec316bf
Compare
dkliban
force-pushed
the
7210
branch
3 times, most recently
from
dd46ad1 to
0bd61e0
Compare
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
There's still a lot I haven't deeply reviewed yet, but this was getting long and I had a big idea around dispatch that I want to discuss
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
Lots of comment/logging statements to remove. Need more specificity on the try/except blocks. And finally there are gaps in the task logic that need to be addressed.
dkliban
force-pushed
the
7210
branch
2 times, most recently
from
c1653b1 to
ea56670
Compare
dkliban
force-pushed
the
7210
branch
3 times, most recently
from
2ac9198 to
8d4de21
Compare
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
Minor nits, but everything else looks good. Think these should be the last changes needed.
| @pytest.mark.parallel | ||
| def test_immediate_task_execution_in_worker(dispatch_task, monitor_task): |
There was a problem hiding this comment.
These following three tests seem pointless, let's remove them.
| @pytest.mark.parallel | ||
| def test_immediate_task_with_available_resources(dispatch_task, pulpcore_bindings): |
There was a problem hiding this comment.
Same with this test, it is already tested below, let's remove.
There was a problem hiding this comment.
This test specifically exercises the are_resources_available() / acquire_locks() code path that the no-resource test skips entirely.
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
I believe this is ready. Thanks for all the work!
This adds WORKER_TYPE setting. The default value is 'pulpcore'. When 'redis' is selected, the tasking system uses Redis to lock resources. Redis workers produce less load on the PostgreSQL database. closes: pulp#7210 Generated By: Claude Code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
This adds WORKER_TYPE setting. The default value is 'pulpcore'. When 'redis' is selected, the tasking system uses Redis to lock resources. Redis workers produce less load on the PostgreSQL database.
closes: #7210
Generated By: Claude Code.
📜 Checklist
See: Pull Request Walkthrough